-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-sftp-bulk): not mirroring paths toggle for file transfer #50972
Open
aldogonzalez8
wants to merge
12
commits into
master
Choose a base branch
from
aldogonzalez8/source-sftp-bulk/not-mirroring-paths
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(source-sftp-bulk): not mirroring paths toggle for file transfer #50972
aldogonzalez8
wants to merge
12
commits into
master
from
aldogonzalez8/source-sftp-bulk/not-mirroring-paths
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/sftp-bulk
labels
Jan 7, 2025
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/sftp-bulk
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
New Feature for Universal File Transfers: Option for source to suppress subdirectory info during sync
How
When enabled we will not replicate the directory structure in the source but put all the files in the stream root folder of the destination. This will be done by updating the relative_path (cdk change here).
Review guide
airbyte-integrations/connectors/source-sftp-bulk/source_sftp_bulk/spec.py
: Main changes in spec to include the toggle, the rest is integration testing to ensure new functionality.User Impact
Connections using file transfer now will be able to not mirror paths (suppress subdirectory structure) during sync.
Can this PR be safely reverted and rolled back?