Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandas from extras in file-based #45362

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Sep 10, 2024

What

Sources are getting the following errors after the release for async:

  File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/sources/declarative/retrievers/simple_retriever.py", line 12, in <module>
    from airbyte_cdk.sources.declarative.extractors.http_selector import HttpSelector
  File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/sources/declarative/extractors/__init__.py", line 9, in <module>
    from airbyte_cdk.sources.declarative.extractors.response_to_file_extractor import ResponseToFileExtractor
  File "/usr/local/lib/python3.10/site-packages/airbyte_cdk/sources/declarative/extractors/response_to_file_extractor.py", line 11, in <module>
    import pandas as pd
ModuleNotFoundError: No module named 'pandas'.

It seems to be because even though the dependency has been added in the list, it is flagged as extra for file-based

How

Remove it from extras in file-based

Tests

Tested locally by setting airbyte-cdk = {path = "../../../airbyte-cdk/python/", develop = true} in source-declarative-manifest and running poetry lock --no-update. We can see the dependency added in the lock file

User Impact

The sources should not install pandas and therefore not fail with the module not found

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Sep 10, 2024 4:44pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 10, 2024
@maxi297
Copy link
Contributor Author

maxi297 commented Sep 10, 2024

/approve-regression-tests

Check job output.

✅ Approving regression tests

@maxi297 maxi297 merged commit b672bc0 into master Sep 10, 2024
32 of 35 checks passed
@maxi297 maxi297 deleted the maxi297/fix-pandas-dependency-issue branch September 10, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants