Remove pandas from extras in file-based #45362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sources are getting the following errors after the release for async:
It seems to be because even though the dependency has been added in the list, it is flagged as extra for file-based
How
Remove it from extras in file-based
Tests
Tested locally by setting
airbyte-cdk = {path = "../../../airbyte-cdk/python/", develop = true}
in source-declarative-manifest and runningpoetry lock --no-update
. We can see the dependency added in the lock fileUser Impact
The sources should not install pandas and therefore not fail with the module not found
Can this PR be safely reverted and rolled back?