Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Increase max file size in import config upgrade process (error 413) #4146

Merged
merged 1 commit into from
Jun 16, 2021
Merged

🐛 Increase max file size in import config upgrade process (error 413) #4146

merged 1 commit into from
Jun 16, 2021

Conversation

marcosmarxm
Copy link
Member

What

This solves (partially) #4086

I had downloaded the configuration from demo.airbyte. It's 12Mb compressed.
Try to import without modification and got error 413.
After change the nginx I built the webapp using dev tag and try again running v1/deployment/import

How

Increase the file size limit in the nginx config file.

Recommended reading order

  1. airbyte-webapp/nginx/default.conf.template

@marcosmarxm marcosmarxm requested review from jrhizor and cgardens June 15, 2021 23:25
cgardens
cgardens approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves (partially) #4086

Why is it only a partial fix? It looks good to me!

@marcosmarxm
Copy link
Member Author

@cgardens some config files like JOB.YAML (166Mb) and ATTEMPTS.YAML(56Mb) are increasing in a fast pace. We need to handle the export/import for config in a better way. Values are from files after decompressed the .tar.gz file. Do you think #3605 can solve the long-term problem?

@marcosmarxm marcosmarxm merged commit 85ee72d into master Jun 16, 2021
@marcosmarxm marcosmarxm deleted the marcosmarxm/increase-nginx-client-max-file branch June 16, 2021 00:36
@marcosmarxm marcosmarxm changed the title Increase file size for import config 🐛 Increase file size for import config Jun 16, 2021
@marcosmarxm marcosmarxm changed the title 🐛 Increase file size for import config 🐛 Increase file size in import config upgrade process (error 413) Jun 16, 2021
@marcosmarxm marcosmarxm changed the title 🐛 Increase file size in import config upgrade process (error 413) 🐛 Increase max file size in import config upgrade process (error 413) Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosmarxm @jrhizor @cgardens