🐛 Source Linkedin Ads: Fix issue where Accounts stream did not correctly handle provided account IDs
#38013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
askarpets
approved these changes
May 7, 2024
| @@ -11,7 +11,7 @@ data: | |||
| connectorSubtype: api | |||
| connectorType: source | |||
| definitionId: 137ece28-5434-455c-8f34-69dc3782f451 | |||
| dockerImageTag: 2.1.0 | |||
| dockerImageTag: 2.1.1 | |||
There was a problem hiding this comment.
please remove dockerImageTag: 2.0.0 as issue is fixed now
| @@ -175,7 +175,7 @@ def test_next_page_token(self, requests_mock, response_json, expected): | |||
| assert expected == result | |||
|
|
|||
| def test_request_params(self): | |||
| expected = "pageSize=500&q=search&search=(id:(values:List(1,2)))" | |||
| expected = "pageSize=500&q=search&search=(id:(values:List(urn%3Ali%3AsponsoredAccount%3A1,urn%3Ali%3AsponsoredAccount%3A2)))" | |||
There was a problem hiding this comment.
should we add test config with account ids for check in cat to prevent similar issue in future?
darynaishchenko
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed an issue where the Accounts stream did not correctly handle provided account IDs. Resolves: https://github.com/airbytehq/oncall/issues/5218
How
The format of IDs used for searches has changed from just an ID to a URN. Additionally, unlike all other search strings, URNs should be URL-encoded.
Added a new config for CAT to test multiple account IDs.
User Impact
Fixed an issue with the Accounts stream that occurred when account IDs were provided.
Can this PR be safely reverted and rolled back?