Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk Support: add %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats #37723

Merged
merged 4 commits into from
Apr 30, 2024
Merged

🐛 Source Zendesk Support: add %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats #37723

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f5e9d3
add %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats
darynaishchenko Apr 30, 2024
5ddfe0a
updated changelog
darynaishchenko Apr 30, 2024
f552606
added format to all cursors
darynaishchenko Apr 30, 2024
948f322
Merge branch 'master' into daryna/source-zendesk-support/add-datetime…
darynaishchenko Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 79c1aa37-dae3-42ae-b333-d1c105477715
dockerImageTag: 2.6.0
dockerImageTag: 2.6.1
dockerRepository: airbyte/source-zendesk-support
documentationUrl: https://docs.airbyte.com/integrations/sources/zendesk-support
githubIssueLabel: source-zendesk-support
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "2.6.0"
version = "2.6.1"
name = "source-zendesk-support"
description = "Source implementation for Zendesk Support."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ definitions:
type: DatetimeBasedCursor
cursor_datetime_formats:
- "%Y-%m-%dT%H:%M:%SZ"
- "%Y-%m-%dT%H:%M:%S%z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this cursor format also be added to audit_logs_stream and cursor_incremental_sync?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it failed on ticket_forms stream, so I prefer do not change not affected streams.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to audit_logs_stream and cursor_incremental_sync

datetime_format: "%Y-%m-%dT%H:%M:%SZ"
cursor_field: "{{ parameters.get('cursor_field', 'updated_at') }}"
start_datetime:
Expand Down
Loading
Loading