Destination Postgres: Upgrade to latest CDK #37660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edgao
commented
Apr 29, 2024
•
edgao
commented
- fix breaking signature changes (some of these are from other PRs, some are from Java CDK updates for mysql #36929 / Java CDK: DV2 tests have separate testcases for safe_cast #36935)
- update expected records files to match the input records defined in Java CDK: DV2 tests have separate testcases for safe_cast #36935
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
f253849 to
c735463
Compare
edgao
commented
Apr 29, 2024
| protected List<String> createIndexSql(final StreamConfig stream, final String suffix) { | ||
| if (stream.getDestinationSyncMode() == DestinationSyncMode.APPEND_DEDUP && !stream.getPrimaryKey().isEmpty()) { | ||
| return List.of( | ||
| getDslContext().createIndex().on( |
There was a problem hiding this comment.
in createTable, we're already creating an index on pk, cursor, extracted_at. Creating an index on just pk is redundant.
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
c735463 to
6914e51
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be524ad to
be73530
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
6914e51 to
6fea617
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be73530 to
55e7bf2
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
6fea617 to
08fe9f0
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
55e7bf2 to
bdf95d2
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
08fe9f0 to
73480ab
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
bdf95d2 to
1dfc87d
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
73480ab to
b82b75d
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
2 times, most recently
from
be36130 to
9bb61fe
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
b82b75d to
ecd02ed
Compare
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
ecd02ed to
a3324c7
Compare
stephane-airbyte
approved these changes
May 6, 2024
edgao
force-pushed
the
edgao/postgres_cdk_bumps
branch
from
a3324c7 to
9a64f6d
Compare
octavia-squidington-iii
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.