Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Linkedin Ads: Update API version to 202404 #37573

Merged

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Apr 25, 2024

What

This update introduces several enhancements to the LinkedIn Ads source, addressing key issues and optimizing data retrieval:

  • API Version Update: Upgraded the LinkedIn Ads API to version 202404. Resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/6556
  • Cursor-based Pagination: Implemented cursor-based pagination for endpoints supporting it, enhancing data fetching efficiency.
  • Analytics Streams Slicing Fix: Adjusted the slicing format for analytics streams to align with the base class requirements, resolving compatibility issues.

How

  • Pagination: Implemented using the pageSize and pageToken parameters to navigate through data pages effectively.
  • Slicing Fix: Ensured the slice format matches the expected structure in the base class to prevent runtime errors.

Previously, an incorrect slice format led to the following error, which has now been corrected:

Traceback (most recent call last):
  File "/airbytehq/airbyte/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/abstract_source.py", line 129, in read
    yield from self._read_stream(
  File "/airbytehq/airbyte/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/abstract_source.py", line 229, in _read_stream
    for record_data_or_message in record_iterator:
  File "/airbytehq/airbyte/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/streams/core.py", line 138, in read
    yield slice_logger.create_slice_log_message(_slice)
  File "/airbytehq/airbyte/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/utils/slice_logger.py", line 28, in create_slice_log_message
    printable_slice = dict(_slice) if _slice else _slice
ValueError: dictionary update sequence element #0 has length 3; 2 is required

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:29am

@tolik0 tolik0 force-pushed the tolik0/source-linkedin-ads/update-api-version-to-202402 branch from 01e4535 to d3a2d5c Compare April 25, 2024 12:15
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Apr 25, 2024
@tolik0 tolik0 changed the title ✨ Source Linkedin Ads: Update API version to 202402 ✨ Source Linkedin Ads: Update API version to 202404 Apr 30, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 2, 2024
@tolik0 tolik0 marked this pull request as ready for review May 2, 2024 08:23
@tolik0 tolik0 requested a review from a team May 2, 2024 08:23
@tolik0 tolik0 self-assigned this May 2, 2024
@tolik0 tolik0 merged commit 231bc52 into master May 2, 2024
38 checks passed
@tolik0 tolik0 deleted the tolik0/source-linkedin-ads/update-api-version-to-202402 branch May 2, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants