fix kotlin warnings in db-sources CDK submodule #37482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/04-22-fix_kotlin_warnings_in_db-sources_cdk_submodule
branch
from
076187f to
e99cdaf
Compare
stephane-airbyte
force-pushed
the
stephane/04-22-fix_kotlin_warnings_in_db-sources_cdk_submodule
branch
from
e99cdaf to
05aa676
Compare
postamar
reviewed
Apr 23, 2024
| * | ||
| * @return set of system namespaces(schemas) to be excluded | ||
| */ | ||
| get |
There was a problem hiding this comment.
nit: we might instead want preserve the comment as a comment on the val itself.
On the other hand, this field is fairly self-explanatory. Up to you.
postamar
reviewed
Apr 23, 2024
| @@ -24,7 +24,7 @@ open class SourceStateIterator<T>( | |||
| private var lastCheckpoint: Instant = Instant.now() | |||
|
|
|||
| override fun computeNext(): AirbyteMessage? { | |||
| var iteratorHasNextValue = false | |||
| var iteratorHasNextValue: Boolean | |||
There was a problem hiding this comment.
fyi you can also var iteratorHasNextValue: Boolean = try { ... though there's no benefit to readability whatsoever in this case
postamar
approved these changes
Apr 23, 2024
stephane-airbyte
deleted the
stephane/04-22-fix_kotlin_warnings_in_db-sources_cdk_submodule
branch
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
fixing kotlin warnings in CDK db-sources submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing kotlin warnings in CDK db-sources submodule