Rename File format related classes to be agnostic of S3 #37442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gisripa
commented
Apr 19, 2024
| @@ -46,7 +47,7 @@ private val logger = KotlinLogging.logger {} | |||
| * data will be buffered in such a hadoop file. | |||
| */ | |||
| class ParquetSerializedBuffer( | |||
| config: S3DestinationConfig, | |||
| uploadFormatConfig: UploadFormatConfig, | |||
There was a problem hiding this comment.
This was the main change, decoupling ParquetBuffer from S3 bucket configs. Rest all are renames.
edgao
approved these changes
Apr 19, 2024
| @@ -46,7 +46,7 @@ class GcsParquetWriter( | |||
|
|
|||
| init { | |||
| val outputFilename: String = | |||
| BaseGcsWriter.Companion.getOutputFilename(uploadTimestamp, S3Format.PARQUET) | |||
| BaseGcsWriter.Companion.getOutputFilename(uploadTimestamp, FileUploadFormat.PARQUET) | |||
| outputPath = java.lang.String.join("/", outputPrefix, outputFilename) | |||
| LOGGER.info( | |||
| "Storage path for stream '{}': {}/{}", | |||
There was a problem hiding this comment.
This whole class and the one above look suspicious. This init seems to be doing the same thing except for odd differences, like using an s3:// address here.... I'm definitely in need of understanding those thing better...
There was a problem hiding this comment.
(just to be clear, I understand that this came from the autoformatting, so I'm not expecting any changes from you)
stephane-airbyte
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Renaming classes which are agnostic to S3.
Review guide
S3FormattoFileUploadFormatParquetSerializedBufferUser Impact
No Functional changes
Can this PR be safely reverted and rolled back?