🐛 [source-facebook-marketing] Should not run migration if the legacy field account_id is not present #37367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
girarda
reviewed
Apr 17, 2024
| @@ -38,7 +38,7 @@ def should_migrate(cls, config: Mapping[str, Any]) -> bool: | |||
| > False, otherwise. | |||
| > Raises the Exception if the structure could not be migrated. | |||
| """ | |||
| return False if config.get(cls.migrate_to_key) else True | |||
| return False if config.get(cls.migrate_to_key) or not config.get(cls.migrate_from_key) else True | |||
There was a problem hiding this comment.
nit: can we simplify this to
return cls.migrate_from_key in config and cls.migrate_from_key not in config
?
There was a problem hiding this comment.
i think you meant return cls.migrate_from_key in config and cls.migrate_to_key not in config. In your snippet you have migrate_from_key twice.
But agree will fix this!
girarda
approved these changes
Apr 17, 2024
bazarnov
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/airbytehq/oncall/issues/4131
We have a bug in our migration code where when we attempt to migrate connections that do not have the legacy
account_idand then crash when we read the config object.This change fixes when we should run the migration by skipping the migration when
account_iddoes not exist and therefore nothing needs to be migrated. I'm not 100% sure how this gets triggered because the new fieldaccount_idsis required, but it could be customers using a side path instead of Airbyte's UI.