-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set maxSecondsBetweenMessages value for certified connectors Phase 3 #36856
Merged
octavia-approvington
merged 23 commits into
master
from
DanyloGL/adding_maxSecondsBetweenMessages_value_for_certified_connectors_Phase_3
Apr 5, 2024
Merged
Set maxSecondsBetweenMessages value for certified connectors Phase 3 #36856
octavia-approvington
merged 23 commits into
master
from
DanyloGL/adding_maxSecondsBetweenMessages_value_for_certified_connectors_Phase_3
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
connectors/source/surveymonkey
connectors/source/amplitude
connectors/source/amazon-ads
connectors/source/chargebee
connectors/source/freshdesk
connectors/source/gitlab
connectors/source/file
connectors/source/greenhouse
connectors/source/iterable
connectors/source/jira
connectors/source/slack
connectors/source/mailchimp
connectors/source/paypal-transaction
connectors/source/pinterest
connectors/source/recharge
connectors/source/sendgrid
connectors/source/twilio
connectors/source/typeform
labels
Apr 5, 2024
lazebnyi
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approve-and-merge reason="batch changes of maxSecondsBetweenMessages in metadata.yaml files" |
octavia-approvington
approved these changes
Apr 5, 2024
octavia-approvington
deleted the
DanyloGL/adding_maxSecondsBetweenMessages_value_for_certified_connectors_Phase_3
branch
April 5, 2024 14:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
connectors/source/airtable
connectors/source/amazon-ads
connectors/source/amplitude
connectors/source/chargebee
connectors/source/file
connectors/source/freshdesk
connectors/source/gitlab
connectors/source/greenhouse
connectors/source/harvest
connectors/source/iterable
connectors/source/jira
connectors/source/mailchimp
connectors/source/monday
connectors/source/notion
connectors/source/paypal-transaction
connectors/source/pinterest
connectors/source/recharge
connectors/source/sendgrid
connectors/source/slack
connectors/source/snapchat-marketing
connectors/source/surveymonkey
connectors/source/twilio
connectors/source/typeform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certified connectors is requirement to have
maxSecondsBetweenMessages
set in metadata file.maxSecondsBetweenMessages
is the longest time frame (in seconds) of API requests limits reset for endpoints used by connector.What
maxSecondsBetweenMessages
value for the following connectors was added:maxSecondsBetweenMessages: 1
. Longest time frame of limits reset is 1 secondmaxSecondsBetweenMessages: 86400
. Longest time frame of limits reset is 1 day or 86400 secondsmaxSecondsBetweenMessages: 1
. Longest time frame of limits reset is 1 secondmaxSecondsBetweenMessages: 60
. Longest time frame of limits reset is 1 minute or 60 secondsmaxSecondsBetweenMessages: 1
. Longest time frame of limits reset is 1 secondmaxSecondsBetweenMessages: 60
. Longest time frame of limits reset is 1 minute or 60 secondsmaxSecondsBetweenMessages: 10
. Longest time frame of limits reset is 10 secondsmaxSecondsBetweenMessages: 15
. Longest time frame of limits reset is 15 secondsmaxSecondsBetweenMessages: 60
. Longest time frame of limits reset is 1 minute or 60 secondsmaxSecondsBetweenMessages: 86400
. Longest time frame of limits reset is 1 day or 86400 secondsmaxSecondsBetweenMessages: 5400
. Longest time frame of limits reset based on billing plan is 1 month. Set value to 90 minutes (5400 seconds) as 1 month is to long time to keep connection.maxSecondsBetweenMessages: 86400
. Longest time frame of limits reset for Behavioral Cohorts API that is used by connector is 1 month. Set value to 1 day (86400 seconds) as 1 month is to long time to keep connection and there is no info regarding limits reset time for Export jobs.maxSecondsBetweenMessages: 60
. Longest time frame of limits reset is 1 minute or 60 secondsmaxSecondsBetweenMessages: 300
. Longest time frame of limits reset is 5 minutes or 300 secondsmaxSecondsBetweenMessages: 120
. Longest time frame of limits reset is 2 minutes or 120 secondsmaxSecondsBetweenMessages: 60
. Longest time frame of limits reset is 1 minute or 60 secondsmaxSecondsBetweenMessages: 5400
. As it's hard to define some value, platform default value is set: 90 minutes or 5400 seconds.maxSecondsBetweenMessages: 5400
. As there is no requests rate limits time reset specified platform default value is set: 90 minutes or 5400 seconds - linkmaxSecondsBetweenMessages: 5400
. As there is no requests rate limits time reset specified platform default value is set: 90 minutes or 5400 secondsmaxSecondsBetweenMessages: 5400
. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - linkmaxSecondsBetweenMessages: 5400
. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - linkmaxSecondsBetweenMessages: 5400
. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - linkmaxSecondsBetweenMessages: 1
. Longest time frame of limits reset is 1 secondHow
Files
metadata.yaml
for connectors mentioned above were updated by addingmaxSecondsBetweenMessages
value.🚨 User Impact 🚨
No breaking changes