Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxSecondsBetweenMessages value for certified connectors Phase 3 #36856

Conversation

DanyloGL
Copy link
Collaborator

@DanyloGL DanyloGL commented Apr 5, 2024

For certified connectors is requirement to have maxSecondsBetweenMessages set in metadata file.
maxSecondsBetweenMessages is the longest time frame (in seconds) of API requests limits reset for endpoints used by connector.

What

maxSecondsBetweenMessages value for the following connectors was added:

  • source-notion: maxSecondsBetweenMessages: 1. Longest time frame of limits reset is 1 second
  • source-pinterest: maxSecondsBetweenMessages: 86400. Longest time frame of limits reset is 1 day or 86400 seconds
  • source-recharge: maxSecondsBetweenMessages: 1. Longest time frame of limits reset is 1 second
  • source-slack: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-snapchat-marketing: maxSecondsBetweenMessages: 1. Longest time frame of limits reset is 1 second
  • source-freshdesk: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-greenhouse: maxSecondsBetweenMessages: 10. Longest time frame of limits reset is 10 seconds
  • source-harvest: maxSecondsBetweenMessages: 15. Longest time frame of limits reset is 15 seconds
  • source-iterable: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-surveymonkey: maxSecondsBetweenMessages: 86400. Longest time frame of limits reset is 1 day or 86400 seconds
  • source-airtable: maxSecondsBetweenMessages: 5400. Longest time frame of limits reset based on billing plan is 1 month. Set value to 90 minutes (5400 seconds) as 1 month is to long time to keep connection.
  • source-amplitude: maxSecondsBetweenMessages: 86400. Longest time frame of limits reset for Behavioral Cohorts API that is used by connector is 1 month. Set value to 1 day (86400 seconds) as 1 month is to long time to keep connection and there is no info regarding limits reset time for Export jobs.
  • source-gitlab: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-chargebee: maxSecondsBetweenMessages: 300. Longest time frame of limits reset is 5 minutes or 300 seconds
  • source-mailchimp: maxSecondsBetweenMessages: 120. Longest time frame of limits reset is 2 minutes or 120 seconds
  • source-monday: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-file: maxSecondsBetweenMessages: 5400. As it's hard to define some value, platform default value is set: 90 minutes or 5400 seconds.
  • source-jira: maxSecondsBetweenMessages: 5400. As there is no requests rate limits time reset specified platform default value is set: 90 minutes or 5400 seconds - link
  • source-amazon-ads: maxSecondsBetweenMessages: 5400. As there is no requests rate limits time reset specified platform default value is set: 90 minutes or 5400 seconds
  • source-twilio: maxSecondsBetweenMessages: 5400. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - link
  • source-sendgrid: maxSecondsBetweenMessages: 5400. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - link
  • source-paypal-transcation: maxSecondsBetweenMessages: 5400. As there is no requests rate limits time reset specified, platform default value is set: 90 minutes or 5400 seconds - link
  • source-typeform: maxSecondsBetweenMessages: 1. Longest time frame of limits reset is 1 second

How

Files metadata.yaml for connectors mentioned above were updated by adding maxSecondsBetweenMessages value.

🚨 User Impact 🚨

No breaking changes

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Apr 5, 2024 1:54pm

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lazebnyi
Copy link
Collaborator

lazebnyi commented Apr 5, 2024

/approve-and-merge reason="batch changes of maxSecondsBetweenMessages in metadata.yaml files"

@octavia-approvington
Copy link
Contributor

Lets do it!
giddddy-up

@octavia-approvington octavia-approvington merged commit a750e46 into master Apr 5, 2024
55 of 77 checks passed
@octavia-approvington octavia-approvington deleted the DanyloGL/adding_maxSecondsBetweenMessages_value_for_certified_connectors_Phase_3 branch April 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment