enable spotbugs for cdk typing_and_deduping submodule #36701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 29, 2024
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
cf29dc8 to
c5afa4e
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
0220354 to
04c031d
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
c5afa4e to
0911db2
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
04c031d to
8dd57b7
Compare
postamar
approved these changes
Apr 2, 2024
| } | ||
| } | ||
| linkedMapOf( | ||
| generator!!.buildColumnId("id1") to AirbyteProtocolType.INTEGER, |
There was a problem hiding this comment.
Can we make generator a non-nullable type? it's a two-liner (definition and assignment)
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
0911db2 to
f0f8945
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
8dd57b7 to
25219a7
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
f0f8945 to
9625001
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
25219a7 to
d8a5cf3
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
9625001 to
95af1a0
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
d8a5cf3 to
2c48f76
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
95af1a0 to
d8b4502
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
2c48f76 to
59bb20c
Compare
Merge activity
|
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
branch
from
d8b4502 to
78f46b4
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
59bb20c to
5a11e42
Compare
Base automatically changed from
stephane/03-28-enable_spotbugs_for_cdk_core_submodule
to
master
April 3, 2024 18:43
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
from
5a11e42 to
bf1886d
Compare
stephane-airbyte
deleted the
stephane/03-28-enable_spotbugs_for_cdk_typing_and_deduping_submodule
branch
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.