-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: burst gradle task cache on new java cdk release #36480
airbyte-ci: burst gradle task cache on new java cdk release #36480
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
deafcff
to
df5f805
Compare
df5f805
to
12cb59a
Compare
12cb59a
to
4fddfa7
Compare
This seems like overkill for a very transient problem. The airbyte-ci codebase is already exceedingly complex and I'm not keen to add mysterious code to handle edge cases like these. Can we instead bust the cache by having the user check a box when running the workflow manually in the github actions page? |
The implementation would be slightly more complex and would only work on workflow dispatch... |
Why is the CDK special? This failure mode can occur with literally any dependency. It's more likely to happen with the CDK because we're hosting it in our own (rather shitty) maven repo instead of pulling from maven central. |
I think the CDK is special as developers reference its version in connectors before actually publishing it. This is what's causing the problem. |
4fddfa7
to
89e1dbd
Compare
Sorry, I'd overlooked this very important point! |
* master: (1562 commits) ✨ source-google-drive: migrate to poetry (airbytehq#36581) enable spotbugs for CDK core and dependencies submodule (airbytehq#36612) ✨ Source Salesforce, Shopify: add maxSecondsBetweenMessages in metadata (airbytehq#36723) java-cdk: re-export airbyte-api dependency (airbytehq#36759) Source Google Sheets: address dependency conflict and update CDK (airbytehq#36515) Airbyte CI: rename incorrectly named pipelines (airbytehq#36722) Source Azure Blob Storage: add integration tests (airbytehq#36542) Salesforce: retry on download_data and create_stream_job (airbytehq#36385) ✨Source Monday: Bumped CDK version dependency (airbytehq#36746) airbyte-ci: burst gradle task cache on new java cdk release (airbytehq#36480) chore(connectors): remove tasks.py and top-level requirements.txt (airbytehq#36738) airbyte-ci: fix pull-request-number option for migrate_to_base_image (airbytehq#36779) 🤖 Bump patch version of Python CDK add backward compatibility for an old close slice logic (airbytehq#36774) Bump Airbyte version from 0.57.0 to 0.57.1 🤖 Bump patch version of Python CDK low-code: Fix cursor pagination instantiation if the stop_condition is a string (airbytehq#36760) fix rabbitmq icon and simplify docs registry code (airbytehq#36767) Update azure-entra-id.md (airbytehq#36758) re-enable rabbitmq on OSS (airbytehq#36749) ...
We want to burst the gradle dependency cache when a new CDK version is published.