-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octavia Segment MTU fix #20543
Octavia Segment MTU fix #20543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the octavia-cli-build
gradle build did not run in the CI 🤔
Pinged the infra team to understand why the Airbyte CI workflow didn't run, but build succeeds locally and it should run on merge to master so going to merge this one. |
What
Describe what the change is solving
Preventing 1 new MTU per anonymous CLI usage
How
Describe the solution
Instead of generating a random UUID for each user, we will instead just set their user ID to "anonymous".
We lose nothing since we're already unable to break down anonymous requests by user.
🚨 User Impact 🚨
None
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.