🪟 🐛 Fix JobService for jobs without attempts #20527
Merged
+27
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are sometimes jobs that don't have any attempts (yet). When we load them this code broke, since we tried to access
attempt.endedAt
onundefined
now. Fixed this to make sure we have any attempts actually before trying to get the last one.Since we can't fetch any logs in this case, we're actually just showing now a simple error message when the job is expanded:
The code below that line already handled the case when
lastAttemptEndTimestamp
is undefined.