Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎉 Custom connectors in cloud UI #20483

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Dec 14, 2022

What

Enables the UI for creating and updating custom connectors in Airbyte Cloud.

Closes https://github.com/airbytehq/airbyte-cloud/issues/3572

How

  • Enables "+ New connectors" button in cloud (will be done by overriding the featureService)
  • Shows the "Change to" column in the list of sources/destinations. Users can change the versions of custom connectors only.

🚨 User Impact 🚨

For the initial rollout, only a small set of users will get FeatureItem.AllowUploadCustomImage added in the cloud environment. After validating the MVP of custom cloud connectors, we'll remove this flag, since both OSS and Cloud users will be able to upload custom images.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 14, 2022
@josephkmh josephkmh marked this pull request as ready for review December 14, 2022 21:58
@josephkmh josephkmh requested a review from a team as a code owner December 14, 2022 21:58
@josephkmh josephkmh requested a review from ambirdsall December 14, 2022 21:58
xiaohansong
xiaohansong previously approved these changes Dec 14, 2022
Copy link
Contributor

@xiaohansong xiaohansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meant to approve on another PR. I don't have expertise on frontend PR though

@xiaohansong xiaohansong dismissed their stale review December 14, 2022 23:35

Was meant to approve another PR, accidentally approved on this one. I don't have FE expertise to approve this PR.

@josephkmh josephkmh requested a review from timroes December 15, 2022 02:50
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, did not test locally

@josephkmh josephkmh merged commit 6b86f50 into master Dec 15, 2022
@josephkmh josephkmh deleted the joey/custom-connectors-cloud-ui branch December 15, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants