Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 airbyte-proxy: Fix 413 Request Entity Too Large nginx/1.23.2 for Airbyte > 0.40.15 #20383

Merged
merged 2 commits into from
Dec 12, 2022
Merged

🐛 airbyte-proxy: Fix 413 Request Entity Too Large nginx/1.23.2 for Airbyte > 0.40.15 #20383

merged 2 commits into from
Dec 12, 2022

Conversation

andresbravog
Copy link
Contributor

@andresbravog andresbravog commented Dec 12, 2022 •
edited
Loading

What

From issue #18822

For long schemas creating the connection fails due to the request payload being over 1M. This issue was introduced with the new airbyte-proxy service as client_max_body_size clause is not set on nginx template and defaults to 1M limit.

How

adding client_max_body_size clause to replicate the one set on airbyte-server nginx.

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

BugFix of service

Community member or Airbyter

@andresbravog andresbravog force-pushed the andresbravog/18822-fix-413-airbyte-proxy branch from e85c0a0 to ec2b82b Compare December 12, 2022 19:44
@octavia-squidington-iv octavia-squidington-iv removed area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 12, 2022
@sajarin sajarin added area/platform issues related to the platform team/prod-eng type/enhancement New feature or request and removed bounty connectors/source/public-apis labels Dec 12, 2022
@sajarin sajarin requested a review from evantahler December 12, 2022 20:16
@octavia-squidington-iv octavia-squidington-iv removed the area/platform issues related to the platform label Dec 12, 2022
evantahler
evantahler approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are some very big schemas!

@evantahler evantahler linked an issue Dec 12, 2022 that may be closed by this pull request
413 Request Entity Too Large nginx/1.23.2 for Airbyte 0.40.15 & above versions #18822
Closed
@evantahler evantahler merged commit c9fb128 into airbytehq:master Dec 12, 2022
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
@sc-yan sc-yan mentioned this pull request Oct 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
community team/prod-eng type/enhancement New feature or request
Projects
No open projects
Community Contributed PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

413 Request Entity Too Large nginx/1.23.2 for Airbyte 0.40.15 & above versions
4 participants
@andresbravog @evantahler @sajarin @octavia-squidington-iv