🪟 🎉 Prevent users from editing existing connection if they have a schema change #20276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
teallarson
changed the title
teallarson
changed the title
teallarson
changed the title
teallarson
changed the title
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
commented
Dec 13, 2022
| /> | ||
| {status.editControlsVisible && ( | ||
| <EditControls | ||
| <SchemaChangeBackdrop |
There was a problem hiding this comment.
only change here is wrapping this in the backdrop
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
changed the base branch from
master
to
anne/update-endpoing-fixes-broken-connection
teallarson
changed the base branch from
anne/update-endpoing-fixes-broken-connection
to
master
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
commented
Dec 13, 2022
...yte-webapp/src/pages/ConnectionPage/pages/ConnectionItemPage/ConnectionPageTitle.module.scss
Outdated
Show resolved
Hide resolved
teallarson
commented
Dec 13, 2022
| /> | ||
| {status.editControlsVisible && ( | ||
| <EditControls | ||
| <SchemaChangeBackdrop> |
There was a problem hiding this comment.
only change here is wrapping the form in the backdrop
teallarson
commented
Dec 13, 2022
| @@ -5,3 +5,6 @@ $sidebar: 9999; | |||
| $panelSplitter: 0; | |||
| $dropdownMenu: 2; | |||
| $notification: 20; | |||
| $schemaChangesBackdrop: 3; | |||
There was a problem hiding this comment.
explicitly set a higher z-index than the dropdown menu and the switch (1)
teallarson
commented
Dec 13, 2022
| @@ -48,7 +48,7 @@ describe("<SchemaChangesDetected />", () => { | |||
|
|
|||
| const { queryByTestId } = renderComponent(); | |||
|
|
|||
| expect(queryByTestId("schemaChagnesDetected")).toBeFalsy(); | |||
| expect(queryByTestId("schemaChangesDetected")).toBeFalsy(); | |||
teallarson
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
teallarson
commented
Dec 13, 2022
|
|
||
| const { getByTestId } = renderComponent(); | ||
|
|
||
| expect(getByTestId("schemaChangesBackdrop")).toMatchSnapshot(); |
There was a problem hiding this comment.
We could test the content directly here for the text, but i don't know a good way to test which .svg is rendered here aside from the snapshot. Open to ideas!
teallarson
removed
connectors/destination/s3
connectors/source/mssql
connectors/source/mysql
connectors/source/pinterest
connectors/source/postgres
connectors/source/snowflake
connectors/source/s3
connectors/destination/databricks
connectors/destination/gcs
connectors/source/twilio
connectors/source/zendesk-support
connectors/source/zenloop
connectors/source/mongodb-v2
connectors/source/relational-db
connectors/source/mssql-strict-encrypt
connectors/source/mysql-strict-encrypt
connectors/source/postgres-strict-encrypt
connectors/source/metabase
connectors/destination/r2
connectors/source/alloydb
connectors/source/alloydb-strict-encrypt
connectors/source/coingecko-coins
connectors/source/gnews
connectors/destination/s3-glue
connectors/source/google-pagespeed-insights
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #20201
How
We would like this to only cover the sync catalog, not the schedule and non-breaking changes preferences dropdown. Because that requires more refactoring of this form, for now we are just blocking the entire form.
Recommended reading order
<SchemaChangeBackdrop/>and its scss module<ConnectionReplicationTab />Testing
Have
REACT_APP_AUTO_DETECT_SCHEMA_CHANGES=truewhen you start the frontend.Make a breaking change to a connection, then refresh the schema and navigate away to trigger the new flow.
If you navigate back to
Replicationtab, you should see the overlay!When you hit
View Changesit should disappear.When you resolve the breaking change and submit, you should not see the overlay.