Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source S3: Check config settings for CSV file format #20262

Merged
merged 14 commits into from
Dec 14, 2022
Merged

🐛 Source S3: Check config settings for CSV file format #20262

merged 14 commits into from
Dec 14, 2022

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Dec 8, 2022 •
edited
Loading

What

Resolving OC #1164 . Check that file can be readed properly.

How

read schema on check_connection

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 8, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/3651423737
❌ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/3651423737
🐛 https://gradle.com/s/zwltbmoh26ils

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::test_check_connection - assert False
	 �[31m============ �[31m�[1m1 failed�[0m, �[32m162 passed�[0m, �[33m10 warnings�[0m�[31m in 69.18s (0:01:09)�[0m�[31m =============�[0m

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 8, 2022
@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 8, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/3652271242
✅ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/3652271242
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1599    332    79%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/jsonl_spec.py                13      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/s3_utils.py                                                20      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source_files_abstract/storagefile.py                       23      1    96%
source_s3/stream.py                                                  43      3    93%
source_s3/source_files_abstract/stream.py                           242     17    93%
source_s3/source_files_abstract/formats/abstract_file_parser.py      39      3    92%
source_s3/source.py                                                  27      4    85%
source_s3/source_files_abstract/formats/csv_parser.py                89     20    78%
source_s3/source_files_abstract/file_info.py                         26      8    69%
source_s3/utils.py                                                   31     10    68%
source_s3/source_files_abstract/source.py                            38     15    61%
source_s3/exceptions.py                                              10      4    60%
source_s3/source_files_abstract/spec.py                              44     22    50%
source_s3/source_files_abstract/formats/jsonl_parser.py              45     27    40%
source_s3/source_files_abstract/formats/avro_parser.py               39     25    36%
source_s3/source_files_abstract/formats/parquet_parser.py            64     44    31%
-------------------------------------------------------------------------------------
TOTAL                                                               862    203    76%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_s3/source_files_abstract/storagefile.py                       23      0   100%
source_s3/source_files_abstract/spec.py                              44      0   100%
source_s3/source_files_abstract/formats/parquet_spec.py               9      0   100%
source_s3/source_files_abstract/formats/jsonl_spec.py                13      0   100%
source_s3/source_files_abstract/formats/csv_spec.py                  16      0   100%
source_s3/source_files_abstract/formats/avro_spec.py                  5      0   100%
source_s3/source.py                                                  27      0   100%
source_s3/s3file.py                                                  37      0   100%
source_s3/exceptions.py                                              10      0   100%
source_s3/__init__.py                                                 2      0   100%
source_s3/source_files_abstract/formats/jsonl_parser.py              45      1    98%
source_s3/source_files_abstract/formats/abstract_file_parser.py      39      1    97%
source_s3/source_files_abstract/formats/parquet_parser.py            64      2    97%
source_s3/stream.py                                                  43      3    93%
source_s3/source_files_abstract/formats/avro_parser.py               39      3    92%
source_s3/source_files_abstract/file_info.py                         26      3    88%
source_s3/source_files_abstract/source.py                            38      5    87%
source_s3/source_files_abstract/stream.py                           242     40    83%
source_s3/s3_utils.py                                                20      4    80%
source_s3/source_files_abstract/formats/csv_parser.py                89     20    78%
source_s3/utils.py                                                   31     10    68%
-------------------------------------------------------------------------------------
TOTAL                                                               862     92    89%

Build Passed

Test summary info:

All Passed

davydov-d
davydov-d reviewed Dec 9, 2022
View reviewed changes
airbyte-integrations/connectors/source-s3/source_s3/source_files_abstract/source.py Outdated
@@ -59,6 +59,7 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) ->
The error object will be cast to string to display the problem to the user.
"""
try:
self.stream_class(**config)._get_master_schema()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could take way too much time if user has thousands of lines in their files. I believe check should be pretty fast. As an option, could we try doing the same just for a small chunk of data in each of the files?

@artem1205 artem1205 requested a review from davydov-d December 12, 2022 20:47
@artem1205 artem1205 requested a review from davydov-d December 13, 2022 13:07
@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/3686900053


Connector Did it publish? Were definitions generated?
connectors/source-s3 ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 changed the title 🐛 Source S3: get master schema on check connection 🐛 Source S3: Check config settings for CSV file format Dec 13, 2022
@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/3687043033


Connector Did it publish? Were definitions generated?
connectors/source-s3 ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/3687329628


Connector Did it publish? Were definitions generated?
connectors/source-s3 ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 13, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/3688927771


Connector Did it publish? Were definitions generated?
connectors/source-s3 ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205
Copy link
Collaborator Author

artem1205 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-s3

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/3698373217


Connector Did it publish? Were definitions generated?
connectors/source-s3 ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 20:47 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 20:48 — with GitHub Actions Inactive
@artem1205 artem1205 merged commit 09cfcbf into master Dec 14, 2022
@artem1205 artem1205 deleted the artem1205/source-s3-value-error-OC-1164 branch December 14, 2022 20:53
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydov-d davydov-d davydov-d approved these changes

@bazarnov bazarnov Awaiting requested review from bazarnov

@grubberr grubberr Awaiting requested review from grubberr

@pedroslopez pedroslopez Awaiting requested review from pedroslopez

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artem1205 @davydov-d @octavia-squidington-iii @octavia-squidington-iv