Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination S3-Glue: fix parsing empty object in schema #19907

Merged
merged 9 commits into from
Dec 14, 2022
Merged

🐛 Destination S3-Glue: fix parsing empty object in schema #19907

merged 9 commits into from
Dec 14, 2022

Conversation

itaseskii
Copy link
Contributor

What

Fixes #19902 (comment)

How

Checking whether object in schema has properties

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@itaseskii itaseskii changed the title fix empty object in schema 🐛 Destination S3-Glue: fix parsing empty object in schema Nov 29, 2022
Copy link
Contributor

@blarghmatey blarghmatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@blarghmatey
Copy link
Contributor

@marcosmarxm would it be possible to get a review on this?

@itaseskii
Copy link
Contributor Author

itaseskii commented Dec 13, 2022

/test connector=connectors/destination-s3-glue

🕑 connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3688349547
❌ connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3688349547
🐛

@itaseskii
Copy link
Contributor Author

itaseskii commented Dec 13, 2022

/test connector=connectors/destination-s3-glue

🕑 connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3688523534
❌ connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3688523534
🐛 https://gradle.com/s/clemcpll7irkk

Build Failed

Test summary info:

Could not find result summary

@itaseskii
Copy link
Contributor Author

itaseskii commented Dec 13, 2022

/test connector=connectors/destination-s3-glue

🕑 connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3689919240
✅ connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/3689919240
No Python unittests run

Build Passed

Test summary info:

All Passed

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 14, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Dec 14, 2022

/publish connector=connectors/destination-s3-glue

🕑 Publishing the following connectors:
connectors/destination-s3-glue
https://github.com/airbytehq/airbyte/actions/runs/3690542336


Connector Did it publish? Were definitions generated?
connectors/destination-s3-glue

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3-glue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

destination-s3-glue: Error when finalizing empty source tables synced to destination
5 participants