add health check endpoint to config api #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 30, 2020
sherifnada
approved these changes
Nov 30, 2020
| HealthCheckRead: | ||
| type: object | ||
| required: | ||
| - db |
There was a problem hiding this comment.
small thing but just db is vague, maybe db_healthy
There was a problem hiding this comment.
this is how we did it for unblocker. why the change of heart? will it be clearer when we add other attributes or less clear?
There was a problem hiding this comment.
probably more clear -- I'm good with it either way but it saves the 1 second of mental mapping from db to db_healthy in my head
michel-tricot
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For K8s, our API needs to have a GET endpoint that can be used as a health check. Goal of this PR is to get something up for a health check. We should add more things we test in the health check as we go.
#835
#1102