Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the destination data type tests to use the new data types #17644

Closed
Tracked by #17637
edgao opened this issue Oct 5, 2022 · 1 comment · Fixed by #19281
Closed
Tracked by #17637

Update the destination data type tests to use the new data types #17644

edgao opened this issue Oct 5, 2022 · 1 comment · Fixed by #19281
Assignees
Labels
team/destinations Destinations team's backlog

Comments

@edgao
Copy link
Contributor

edgao commented Oct 5, 2022

We should keep the old-style catalog+message files for connectors which haven't been updated, and add some sort of supportsWellKnownDataTypes flag in the DAT base class to select the appropriate catalog. Or maybe we can take advantage of platform's protocol versioning logic here.

Definition of done:

  • all DDTs can be run with new protocol version
  • all DDTs still run and pass with old protocol version

Caveat: cannot fully verify this E2E until there is a destination that supports new protocol version

@edgao edgao added team/destinations Destinations team's backlog and removed team/triage labels Oct 5, 2022
@grishick
Copy link
Contributor

grishick commented Nov 3, 2022

Notes from grooming:

We'll need to add a flag/method to DestinationAcceptanceTest that tells if the destination supports DATs with the new protocol. It might make sense for this flag/method to return "does not support" by default.

Before implementing the changes: run all DATs on master and take note of the failing tests (ideally also file github issues for them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/destinations Destinations team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants