You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the corresponding *_messages.txt files with string-wrapped numbers
We should keep the old-style catalog+message files for connectors which haven't been updated, and add some sort of supportsWellKnownDataTypes flag in the DAT base class to select the appropriate catalog. Or maybe we can take advantage of platform's protocol versioning logic here.
Definition of done:
all DDTs can be run with new protocol version
all DDTs still run and pass with old protocol version
Caveat: cannot fully verify this E2E until there is a destination that supports new protocol version
The text was updated successfully, but these errors were encountered:
alternative approach is to create catalog and message files according to the new version
We'll need to add a flag/method to DestinationAcceptanceTest that tells if the destination supports DATs with the new protocol. It might make sense for this flag/method to return "does not support" by default.
Before implementing the changes: run all DATs on master and take note of the failing tests (ideally also file github issues for them).
$ref
types (e.g. https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/bases/standard-destination-test/src/main/resources/data_type_basic_test_catalog.json)*_messages.txt
files with string-wrapped numbersWe should keep the old-style catalog+message files for connectors which haven't been updated, and add some sort of
supportsWellKnownDataTypes
flag in the DAT base class to select the appropriate catalog. Or maybe we can take advantage of platform's protocol versioning logic here.Definition of done:
Caveat: cannot fully verify this E2E until there is a destination that supports new protocol version
The text was updated successfully, but these errors were encountered: