Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data types update - destinations #17637

Closed
8 tasks done
edgao opened this issue Oct 5, 2022 · 1 comment
Closed
8 tasks done

data types update - destinations #17637

edgao opened this issue Oct 5, 2022 · 1 comment
Labels
Epic team/destinations Destinations team's backlog

Comments

@edgao
Copy link
Contributor

edgao commented Oct 5, 2022

(this does not depend on #17639, because it's purely about consuming the new protocol rather than forcing anyone to use it)

Once #17486 is approved and merged, we need to make these changes:

Once those tasks are complete, we can start upgrading connectors to the new protocol. Specifically, these changes need to happen in each destination connector that cares about data types:

  1. check the catalog for $ref: well_known_types....Foo rather than checking {type: foo} (/ airbyte_type / format)
  2. handle stringified numeric values (int/float/etc)
  3. handle binary data (a v0 implementation is to just treat it as a string, since the JSON blob will contain the base64-encoded data rather than raw binary)

Affected destinations:

@edgao
Copy link
Contributor Author

edgao commented Oct 20, 2022

@edgao check if databricks needs to be updated

edit: #18548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic team/destinations Destinations team's backlog
Projects
None yet
Development

No branches or pull requests

2 participants