Skip to content

Commit

Permalink
Fixed linter issues
Browse files Browse the repository at this point in the history
  • Loading branch information
ryankfu committed Dec 16, 2022
1 parent 62b9cbb commit aa6dc13
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ public class EnvVariableFeatureFlags implements FeatureFlags {

public static final String USE_STREAM_CAPABLE_STATE = "USE_STREAM_CAPABLE_STATE";
public static final String AUTO_DETECT_SCHEMA = "AUTO_DETECT_SCHEMA";
// Set this value to true to see all messages from the source to destination, set to one second emission
// Set this value to true to see all messages from the source to destination, set to one second
// emission
public static final String LOG_CONNECTOR_MESSAGES = "LOG_CONNECTOR_MESSAGES";
public static final String NEED_STATE_VALIDATION = "NEED_STATE_VALIDATION";
public static final String APPLY_FIELD_SELECTION = "APPLY_FIELD_SELECTION";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@
*
* Two methods are intended for extension:
* <ul>
* <li>startTracked: Wraps set up of necessary infrastructure/configuration before message consumption.</li>
* <li>acceptTracked: Wraps actual processing of each {@link io.airbyte.protocol.models.v0.AirbyteMessage}.</li>
* <li>startTracked: Wraps set up of necessary infrastructure/configuration before message
* consumption.</li>
* <li>acceptTracked: Wraps actual processing of each
* {@link io.airbyte.protocol.models.v0.AirbyteMessage}.</li>
* </ul>
*
* Though not necessary, we highly encourage using this class when implementing destinations. See
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@
* during a sync, so a single instance of this manager is sufficient for a destination to track
* state during a sync.
*
* <p>Strategy: Delegates state messages of each type to a StateManager that is appropriate to that
* state type.</p>
* <p>
* Strategy: Delegates state messages of each type to a StateManager that is appropriate to that
* state type.
* </p>
*
* <p>Per the protocol, if state type is not set, assumes the LEGACY state type.</p>
* <p>
* Per the protocol, if state type is not set, assumes the LEGACY state type.
* </p>
*/
public class DefaultDestStateLifecycleManager implements DestStateLifecycleManager {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@
* stream. In these cases, at each state of the process, it tracks the LAST state message for EACH
* stream (no duplicates!).
*
* <p>Guaranteed to output state messages in order relative to other messages of the SAME state. Does
* <p>
* Guaranteed to output state messages in order relative to other messages of the SAME state. Does
* NOT guarantee that state messages of different streams will be output in the order in which they
* were received. State messages across streams will be emitted in alphabetical order (primary sort
* on namespace, secondary on name).</p>
* on namespace, secondary on name).
* </p>
*/
public class DestStreamStateLifecycleManager implements DestStateLifecycleManager {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public class SerializedBufferingStrategy implements BufferingStrategy {
private final ConfiguredAirbyteCatalog catalog;

/**
* Creates instance of Serialized Buffering Strategy used to handle the logic of flushing buffer with an associated buffer type
* Creates instance of Serialized Buffering Strategy used to handle the logic of flushing buffer
* with an associated buffer type
*
* @param onCreateBuffer type of buffer used upon creation
* @param catalog collection of {@link io.airbyte.protocol.models.ConfiguredAirbyteStream}
Expand All @@ -48,11 +49,11 @@ public SerializedBufferingStrategy(final CheckedBiFunction<AirbyteStreamNameName

/**
* Handles both adding records and when buffer is full to also flush
* TODO: (ryankfu) when buffer is filled up to write to bucket storage or airbyte_raw table
*
* @param stream - stream associated with record
* @param message - {@link AirbyteMessage} to buffer
* @return true if this {@link io.airbyte.protocol.models.AirbyteRecordMessage} causes buffer to flush all messages, otherwise false
* @return true if this {@link io.airbyte.protocol.models.AirbyteRecordMessage} causes buffer to
* flush all messages, otherwise false
* @throws Exception
*/
@Override
Expand Down

0 comments on commit aa6dc13

Please sign in to comment.