-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadBalancerIP to service spec in APIs charts #307
Conversation
Quality Gate passedIssues Measures |
f236e73
to
14bcc3d
Compare
Hi, it's perfect, I also need this for my use case. Thx |
ea55368
to
972aef8
Compare
972aef8
to
ac48904
Compare
@pdemagny For what it's worth, I believe this can already be achieved by adding the following annotation on the
But to make this actually work on GKE, it requires quite a bit of fiddling. This is what I've found (mostly) works for a private GKE Autopilot cluster:
Explanations:
This can still be a little quirky at times, but at least gets most of the objects provisioned (although sometimes I get two sets of backends for some reason). With IAP specifically, I often have to toggle it off and then on again, but I think that's due to the improper validation of those settings (right now it says the oAuth key is required, but with Google-managed it shouldn't be). Some of that may also be that I'm behind a Shared VPC (but honestly for a production deployment, almost everyone should use Shared VPC + Cloud NAT + IAP from a security posture standpoint). Overall I feel that using the named values via annotations in this case is more appropriate . . . do you have a case where you would want to pass the IP literals around that couldn't be covered using And again, this is REALLY hard to find correct info for, and much has changed over time. So I do think there needs to be a way to simplify configuration, especially for GKE. So +1 for making this simpler than all that. |
@pdemagny Apologies, I just realized that you're talking about the API charts, not webapp. I should really read more often! With that said, it seems to make sense that whatever config happens here is made more consistent with the settings for webapp—having completely different configs to expose them seems confusing. (I'm not sure one is better than the other, but it would be nice if they both had the same options exposed and created consistent cluster config either way.) |
ac48904
to
7c7a17c
Compare
What
Hi !
I'd like to add
loadBalancerIP
to service spec to allow use cases such as Internal Load Balancers on Google Kubernetes Engine with static internal IP reserved in advance.It helps with:
See this, this and this.
How
Tested on GKE v1.27.8-gke.1067004 STABLE Release Channel.
Can this PR be safely reverted / rolled back?
If unsure, leave it blank.
🚨 User Impact 🚨
Nothing breaking for anyone, only adds more use cases.