fix(worker): Pass configured tolerations to AsyncOrchestratorPodProcess #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justenwalker
force-pushed
the
jwalker/repl-tolerations
branch
2 times, most recently
from
768ea1a to
0c60b48
Compare
|
@davinchia can we take a look in this contribution? |
justenwalker
force-pushed
the
jwalker/repl-tolerations
branch
from
0c60b48 to
5c6167d
Compare
The previous implementation of AsyncOrchestratorPodProcess did not account for tolerations that are configured for the worker pods; so if a nodeSelector was configured to isolate pods into their own private node group, the lack of a toleration could make these pods unschedulable since they would not tolerate the node taint on such a node group.
justenwalker
force-pushed
the
jwalker/repl-tolerations
branch
from
5c6167d to
6e30bcd
Compare
|
@davinchia rebased. Should hopefully be a straight-forward change; unless there is some other way you'd like to approach this? |
|
|
/create-oss-pr |
|
@justenwalker talking a look! |
|
I've merged this in our internal repo. This should be mirrored out soon. Closing this PR and releasing an OSS version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The previous implementation of AsyncOrchestratorPodProcess did not account for tolerations that are configured for the worker pods; so if a
nodeSelectorwas configured to isolate pods into their own private node group, the lack of a toleration could make these pods unscheduled since they would not tolerate the node taint on such a node group.How
This solution passes the getWorkerKubeTolerations() into the AsyncOrchestratorPodProcess.create method so that the replicator pod that is created is configured with the tolerations that were configured for the job pod.
Recommended reading order
airbyte-commons-worker/src/main/java/io/airbyte/workers/process/AsyncOrchestratorPodProcess.javaairbyte-commons-worker/src/main/java/io/airbyte/workers/sync/LauncherWorker.javaairbyte-workers/src/test-integration/java/io/airbyte/workers/process/AsyncOrchestratorPodProcessIntegrationTest.javaCan this PR be safely reverted / rolled back?
If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.
Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.
If unsure, leave it blank.
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.