Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nginx config for request size and timeouts #129

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

abuchanan-airbyte
Copy link
Collaborator

@abuchanan-airbyte abuchanan-airbyte commented Sep 20, 2024

Set up some nginx config for request body size and timeouts.

Related issues:

Unfortunately, I think this will only work on new installs or uninstall + reinstall. In my tests, I couldn't get this to update my existing ingress.

The request body size is fairly easy to test by creating a postgres source with lots of tables/columns:
Screenshot 2024-09-20 at 11 47 47 AM

after:
image

I'm not sure how to test the timeout setting yet.

@abuchanan-airbyte abuchanan-airbyte requested a review from a team as a code owner September 20, 2024 19:53
@niveditabaliga-payroc
Copy link

Hi @abuchanan-airbyte. When will this be merged in?

@abuchanan-airbyte abuchanan-airbyte merged commit 6e6dfe4 into main Sep 25, 2024
2 checks passed
@abuchanan-airbyte abuchanan-airbyte deleted the abuch/nginx-config branch September 25, 2024 18:57
@niveditabaliga-payroc
Copy link

@abuchanan-airbyte does this merge mean we can repull airbyte using abctl and have the fix?

@abuchanan-airbyte
Copy link
Collaborator Author

@niveditabaliga-payroc we'll cut a release soon that will include this change.

@niveditabaliga-payroc
Copy link

hi @abuchanan-airbyte . We downloaded the new version of abctl (v0.18.0 by running the curl command curl -LsfS https://get.airbyte.com | bash -), ran abctl local install and when we opened up Airbyte, we still faced the HTTP 413 error when setting up a connection to a source DB with over 100 tables. Are you able to guide us on why that would still happen?

@abuchanan-airbyte
Copy link
Collaborator Author

@niveditabaliga-payroc Perhaps you could join the Slack channel, so we can debug the issue https://docs.airbyte.com/community/getting-support

@japerry911
Copy link

@niveditabaliga-payroc

adding annotation to ingress-abctl namespace worked for me -

kubectl edit ingress ingress-abctl -n airbyte-abctl --kubeconfig ~/.airbyte/abctl/abctl.kubeconfig

then add under metadata (50m = 50 mb, if you need more add higher number, etc..)...

metadata:
  annotations:
     nginx.ingress.kubernetes.io/proxy-body-size: "50m" 

Should work momentarily.. Just a temporarily fix though, I don't know if this is best method, but works for me.

@niveditabaliga-payroc
Copy link

thank you for the input @japerry911 . I will remember this in case we run into this issue again. For the time being, the fix released the day before worked after we ran the following commands

  1. curl -LsfS https://get.airbyte.com | bash -
  2. abctl local uninstall
  3. abctl local install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants