Implement a thread-safe Airbrake::Context
#659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
658-thread-safe-context
branch
from
f780472 to
8e9ae4a
Compare
Fixes #658 (Is Airbrake.merge_context thread safe?) This makes sure any operations on the context hash are thread-safe. We do synchronize calls around the code that attaches the context object to the error report but the context object is not thread-safe itself.
kyrylo
force-pushed
the
658-thread-safe-context
branch
from
8e9ae4a to
84c2ec6
Compare
sjain
reviewed
Jun 17, 2021
Comment on lines
+44
to
+53
| context "when another thread is spawned" do | ||
| it "doesn't clash with other threads' contexts" do | ||
| described_class.current.merge!(apples: 'oranges') | ||
| th = Thread.new do | ||
| described_class.current.merge!(foos: 'bars') | ||
| end | ||
| th.join | ||
| expect(described_class.current.to_h).to match(apples: 'oranges') | ||
| end | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658 (Is Airbrake.merge_context thread safe?)
This makes sure any operations on the context hash are thread-safe. We do
synchronize calls around the code that attaches the context object to the error
report but the context object is not thread-safe itself.