Add the route_stats option and make RouteSender respect envs
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
optional-route-stats
branch
from
b45992e to
fdbc24d
Compare
`RouteSender` must respect the `ignore_environments` option because the current behaviour is inconsistent (e.g. we collect route stats but don't send notices). The `route_stats` option allows disabling the feature altogether, no matter what environment is used. When enabled (the default), it will work only in allowed environments. This should be useful for apps that don't have any routes, which protects against unwanted `Airbrake.notify_request` calls. Low tier accounts that don't support the feature should also be configuring this.
kyrylo
force-pushed
the
optional-route-stats
branch
from
fdbc24d to
c41c5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RouteSendermust respect theignore_environmentsoption because the currentbehaviour is inconsistent (e.g. we collect route stats but don't send notices).
The
route_statsoption allows disabling the feature altogether, no matter whatenvironment is used. When enabled (the default), it will work only in allowed
environments. This should be useful for apps that don't have any routes, which
protects against unwanted
Airbrake.notify_requestcalls. Low tier accounts thatdon't support the feature should also be configuring this.