[tooltip] add offset props to <TooltipWithBounds /> #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
The goal of this PR is to fix issues like this where the tooltip overlaps the point:

To do so I added optional
leftOffset
andtopOffset
props to the<TooltipWithBounds />
which offset the finalleft
andtop
positions depending on theboundingClientRect
s it receives fromwithBoundingRects
:+leftOffset
-leftOffset
+topOffset
-topOffset
I also considered creating
computeLeft({ left, rect, parentRect })
andcomputeTop({ top, rect, parentRect })
props that allow the user to fully override the calculation but decided this was a little simpler.Let me know if you have thoughts!
Tested functionally:
