one more pass

airbnb · Dec 17, 2024 · 8e1e475 · 8e1e475
1 parent a9fe9c0
commit 8e1e475
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 17 deletions.
diff --git a/packages/visx-axis/test/AxisRight.test.tsx b/packages/visx-axis/test/AxisRight.test.tsx
@@ -25,9 +25,14 @@ describe('<AxisRight />', () => {
     expect(AxisRight).toBeDefined();
   });
 
-  it('should render with correct class names', () => {
+  it('should render with default props', () => {
     const { container } = renderAxis();
-    expect(container.querySelector('.visx-axis-right')).toBeInTheDocument();
+    const axis = container.querySelector('.visx-axis-right');
+    expect(axis).toBeInTheDocument();
+
+    // Default props are reflected in rendered output
+    const ticks = container.querySelectorAll('.visx-axis-tick');
+    expect(ticks.length).toBeGreaterThan(0);
   });
 
   it('should apply custom class names', () => {
@@ -39,28 +44,16 @@ describe('<AxisRight />', () => {
     };
 
     const { container } = renderAxis(customProps);
-
     expect(container.querySelector('.axis-test-class')).toBeInTheDocument();
     expect(container.querySelector('.axisline-test-class')).toBeInTheDocument();
     expect(container.querySelector('.tick-test-class')).toBeInTheDocument();
   });
 
-  it('should render with default props', () => {
-    const { container } = renderAxis();
-    const axis = container.querySelector('.visx-axis-right');
-    expect(axis).toBeInTheDocument();
-
-    // Default props are reflected in rendered output
-    const ticks = container.querySelectorAll('.visx-axis-tick');
-    expect(ticks.length).toBeGreaterThan(0);
-  });
-
   it('should render with custom props', () => {
     const labelOffset = 3;
     const tickLength = 15;
 
     const { container } = renderAxis({ labelOffset, tickLength });
-
     const axis = container.querySelector('.visx-axis-right');
     expect(axis).toBeInTheDocument();
 
@@ -84,4 +77,37 @@ describe('<AxisRight />', () => {
     const label = container.querySelector('text.visx-axis-label');
     expect(label).toHaveAttribute('transform', 'rotate(90)');
   });
+
+  it('should use default labelOffset of 36', () => {
+    const { container } = renderAxis({
+      label: 'Test Label',
+    });
+    const label = container.querySelector('.visx-axis-label');
+    expect(label?.getAttribute('y')).toBe('-44');
+    expect(label?.getAttribute('x')).toBe('5');
+  });
+
+  it('should apply custom labelOffset', () => {
+    const labelOffset = 3;
+    const { container } = renderAxis({
+      label: 'Test Label',
+      labelOffset,
+    });
+    const label = container.querySelector('.visx-axis-label');
+    expect(label?.getAttribute('y')).toBe('-11');
+    expect(label?.getAttribute('x')).toBe('5');
+  });
+
+  it('should use default tickLength', () => {
+    const { container } = renderAxis();
+    const tick = container.querySelector('.visx-axis-tick line');
+    expect(tick).toHaveAttribute('x2', '8');
+  });
+
+  it('should set custom tickLength', () => {
+    const tickLength = 15;
+    const { container } = renderAxis({ tickLength });
+    const tick = container.querySelector('.visx-axis-tick line');
+    expect(tick).toHaveAttribute('x2', `${tickLength}`);
+  });
 });
diff --git a/packages/visx-group/test/Group.test.tsx b/packages/visx-group/test/Group.test.tsx
@@ -16,7 +16,6 @@ describe('<Group />', () => {
     );
     const group = container.querySelector('.visx-group');
     expect(group).toBeInTheDocument();
-    expect(group?.getAttribute('class')).toBe('visx-group');
   });
 
   test('it should default props top=0 left=0', () => {

diff --git a/packages/visx-marker/test/Arrow.test.tsx b/packages/visx-marker/test/Arrow.test.tsx
@@ -13,7 +13,7 @@ describe('<MarkerArrow />', () => {
     const { container } = render(
       <svg>
         <defs>
-          <MarkerArrow id="marker-circle-test" />
+          <MarkerArrow id="marker-arrow-test" />
         </defs>
       </svg>,
     );
@@ -22,7 +22,7 @@ describe('<MarkerArrow />', () => {
     const polyline = container.querySelector('polyline');
 
     expect(marker).toBeInTheDocument();
-    expect(marker).toHaveAttribute('id', 'marker-circle-test');
+    expect(marker).toHaveAttribute('id', 'marker-arrow-test');
     expect(polyline).toBeInTheDocument();
   });