Fix time filter in dashboard v2 (apache#5412)

airbnb · Jul 25, 2018 · 9fabc04 · 9fabc04
1 parent 488db15
commit 9fabc04
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/superset/assets/src/dashboard/reducers/dashboardState.js b/superset/assets/src/dashboard/reducers/dashboardState.js
@@ -97,8 +97,7 @@ export default function dashboardStateReducer(state = {}, action) {
       const { chart, col, vals: nextVals, merge, refresh } = action;
       const sliceId = chart.id;
       const filterKeys = [
-        '__from',
-        '__to',
+        '__time_range',
         '__time_col',
         '__time_grain',
         '__time_origin',

diff --git a/superset/assets/src/explore/components/controls/DateFilterControl.jsx b/superset/assets/src/explore/components/controls/DateFilterControl.jsx
@@ -176,7 +176,7 @@ export default class DateFilterControl extends React.Component {
   }
   handleClick(e) {
     // switch to `TYPES.CUSTOM_START_END` when the calendar is clicked
-    if (this.startEndSectionRef.contains(e.target)) {
+    if (this.startEndSectionRef && this.startEndSectionRef.contains(e.target)) {
       this.setState({ type: TYPES.CUSTOM_START_END });
     }
   }