[Feature] Update FeedRules logic to factor in TeamID
and SigningID
rules + validation checks
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @MarkVLK
cc: @airbnb/rudolph-maintainers
Background
Update FeedRules logic to factor in
TeamID
andSigningID
rules + validation checks. Since the new rules, not every rule contains a SHA256 or checksum identifier. Rules now contain random identifiers as such so validation checks should be added for each of these new rule types.Changes
TeamID
andSigningID
rulesstate
at which a machine is at when looking at a variety of FeedRules that containteamID
orsigningID
identifiers. This change makes it clear in the current DynamoDB insertion thatIdentifier
field should be usedTesting
Deployed to internal development systems.