Actually fall back to vanilla resolve method when resolveNoRTL does not exist #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucewpaul
approved these changes
Aug 30, 2017
majapw
force-pushed
the
maja-actually-do-sensible-fallback-for-rws-resolve-method
branch
from
2bb2368 to
e7ff56a
Compare
majapw
deleted the
maja-actually-do-sensible-fallback-for-rws-resolve-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally actually fixed #97 and #95.
Basically I wasn't thinking things through, and while #95 never accessed the interface's
resolveNoRTLmethod at all, in #97 it would never be falsey even if that method didn't exist. This addresses both of those problem and should finally be the real solution. :|to: @ljharb @lencioni @airbnb/webinfra