Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time stretch incorrect bug #1818

Merged
merged 2 commits into from
May 29, 2021
Merged

fix time stretch incorrect bug #1818

merged 2 commits into from
May 29, 2021

Conversation

mofic
Copy link
Contributor

@mofic mofic commented May 26, 2021

when i create a lottie use the time stretch property ,i find it perform incorrect in android but it work well in web ,so i fix it.

this is perform in web
animation_500_kp5ia53d

this is perform in android,you can see it different from the web in the end of the video。

Screenrecorder-2021-05-26-21-29-29-248.mp4

this is perform in android after i fix it,it is same of the web

Screenrecorder-2021-05-26-21-34-01-670.mp4

the source test.json

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you drop your test json file in this folder? Then it'll get automatically included in the snapshot regression tests.

@mofic
Copy link
Contributor Author

mofic commented May 27, 2021

hi , i already add it

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gpeal gpeal merged commit 875cecc into airbnb:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants