Cancel loading tasks when a new animation is set #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngsilverman
force-pushed
the
nsilverman-loader-fix
branch
from
ba0d351
to
a1325c7
Compare
gpeal
approved these changes
Nov 30, 2016
| } | ||
|
|
||
| private void cancelLoaderTask() { | ||
| if (loaderTask != null) { |
There was a problem hiding this comment.
Can you also set the loader to null in the listener?
| @@ -70,6 +70,7 @@ public void onCompositionLoaded(LottieComposition composition) { | |||
| private boolean setProgressWhenCompositionSet; | |||
| private boolean playAnimationWhenCompositionSet; | |||
|
|
|||
| @Nullable private LottieComposition.Cancellable loaderTask; | |||
There was a problem hiding this comment.
Can we give this a more descriptive name? Maybe compositionLoder or something?
ngsilverman
force-pushed
the
nsilverman-loader-fix
branch
from
a1325c7
to
74f5653
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example repro steps:
The first loading task would consume the progress setting of
1f, and so the second one would use the default of0f. A similar effect could be achieved withplayAnimation().