Pull out LottieComposition factory methods into inner class #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Feb 21, 2017
gpeal
added a commit
that referenced
this pull request
Jan 9, 2018
Previously, Lottie used JsonObject for deserialization. That meant that: 1) Deserialization is not guaranteed to be O(n) where n is the size of the json file. 2) The entire json string must be loaded into memory. Switching to JsonReader has the following advantages: 1) Reading is guaranteed to be O(n). 2) Large files can be read in buffers. However, deserialization code is much more cumbersome because you can't query for things like the existence of a key, the length of an array, and you can't re-walk the same part of the json multiple times. @felipecsl Did some work (#137, #139, #145, #152) a year ago to prepare to decouple parsing logic so that people could use jackson or some other method of deserialization. However, JsonReader is now the most optimal solution so some of the factory code can be simplified in a future PR. ## Performance Most animations deserialize ~50% faster than before. I was also able to deserialize a 50mb json file in 10s that couldn't come close to completing without OOMing before. |Animation|Old time (ms)|New time (ms)|% improvement| |----------|--------------|--------------|----------------| |Tadah|107|55|48%| |Nudge|100|51|49%| |Notifications|85|48|43%| |Star Wars|74|41|45%| |City|65|24|64%| |9squares|17|7|59%| |Empty State|9|4|56%| |Hello World|6|2|66%| |Hamburger Arrow|2|1|50%| Fixes #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is part of issue #3. Pulled static factory methods out of
LottieCompositioninto a static inner class. Made all fields final and initialized them all in the constructor.This will make it easier for follow up refactors where we'll modularize the parsing logic and make it pluggable.
Also upgraded the Espresso tests to JUnit 4 so it no longer uses the deprecated
ActivityInstrumentationTestCase2Testing
Ran
./gradlew recordMode screenshotTestsand saw no changes to screenshot files.cc @hzsweers