Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted all json to use opt* instead of get* #128

Merged
merged 1 commit into from
Feb 19, 2017
Merged

Converted all json to use opt* instead of get* #128

merged 1 commit into from
Feb 19, 2017

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Feb 19, 2017

  • The parsing code is now cleaner.
  • There is a slight performance improvement using opt* instead of get*. I did some tests and didn't see a significantly measurable improvement but for large files or on certain devices, it may make a difference.

Fixes #123
#3

@gpeal
Copy link
Collaborator Author

gpeal commented Feb 19, 2017

@0legg fyi

@gpeal gpeal merged commit edb7e5b into master Feb 19, 2017
@gpeal gpeal deleted the gpeal/opt branch February 19, 2017 04:40
@comigor comigor mentioned this pull request May 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gpeal