We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The Composition still gets cache in LottieCompositonCache, regardless of the setting. This is because the custom/null cache key is ignored here: https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java#L219. It should be calling fromRawResSync(context, rawRes, cacheKey); instead.
LottieCompositonCache
fromRawResSync(context, rawRes, cacheKey);
It looks like this was missed in ee94224
Steps To Reproduce Steps to reproduce the behavior:
cacheComposition
false
LottieAnimationView
LottieCompositionCache.put
cacheKey
The text was updated successfully, but these errors were encountered:
Add cacheKey to LottieCompositionFactory call (#1617)
ae9317b
Fixes #1556
Successfully merging a pull request may close this issue.
Describe the bug
The Composition still gets cache in
LottieCompositonCache
, regardless of the setting. This is because the custom/null cache key is ignored here: https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java#L219. It should be callingfromRawResSync(context, rawRes, cacheKey);
instead.It looks like this was missed in ee94224
Steps To Reproduce
Steps to reproduce the behavior:
cacheComposition
tofalse
onLottieAnimationView
LottieCompositionCache.put
cacheKey
is non-null, even though it should be null.The text was updated successfully, but these errors were encountered: