Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable cache composition doesn't work #1556

Closed
markrietveld opened this issue Apr 28, 2020 · 0 comments · Fixed by #1617
Closed

Option to disable cache composition doesn't work #1556

markrietveld opened this issue Apr 28, 2020 · 0 comments · Fixed by #1617

Comments

@markrietveld
Copy link

Describe the bug
The Composition still gets cache in LottieCompositonCache, regardless of the setting. This is because the custom/null cache key is ignored here: https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java#L219. It should be calling fromRawResSync(context, rawRes, cacheKey); instead.

It looks like this was missed in ee94224

Steps To Reproduce
Steps to reproduce the behavior:

  1. Set cacheComposition to false on LottieAnimationView
  2. Attach a debugger and set a breakpoint in LottieCompositionCache.put
  3. Load an animation from a raw res
  4. See that cacheKey is non-null, even though it should be null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant