If the chunk fails and we keep the 'slot' as free, make sure to remov…

…e the files from disk
airbnb · Nov 22, 2024 · 4c67f9e · 4c67f9e
1 parent 16d8f56
commit 4c67f9e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/astra/src/main/java/com/slack/astra/chunk/ReadOnlyChunkImpl.java b/astra/src/main/java/com/slack/astra/chunk/ReadOnlyChunkImpl.java
@@ -437,6 +437,11 @@ private void handleChunkAssignment(CacheSlotMetadata cacheSlotMetadata) {
       // disregarding any errors
       setChunkMetadataState(cacheSlotMetadata, Metadata.CacheSlotMetadata.CacheSlotState.FREE);
       LOG.error("Error handling chunk assignment", e);
+      // also clean up downloaded files if the chunk could not be assigned as we're marking the as FREE / available
+      if (Files.isDirectory(dataDirectory)) {
+        LOG.info("Cleaning up directory after failed chunk assignment{}", dataDirectory);
+        cleanDirectory();
+      }
       assignmentTimer.stop(chunkAssignmentTimerFailure);
     } finally {
       chunkAssignmentLock.unlock();