Upgrade to eslint v2 #730

hshoff · 2016-02-12T20:02:04Z

To the future we go. Couple more steps to go before publish:

bump eslint
review additional rules + features in v2
add new rules set to 0
add new rules we want to enforce + add explanations to Readme
bump eslint-plugin-react Roadmap v4.0.0 jsx-eslint/eslint-plugin-react#436
update changelog
publish to npm

ljharb · 2016-02-13T21:26:07Z

packages/eslint-config-airbnb/rules/best-practices.js

@@ -32,7 +32,7 @@ module.exports = {
    // disallow else after a return in an if
    'no-else-return': 2,
    // disallow use of labels for anything other then loops and switches
-    'no-empty-label': 2,
+    'no-labels': [2, { 'allowLoop': true, 'allowSwitch': true }],


we should definitely set both of these to false - we don't allow GOTO in any form, including breaking to a label.

hshoff · 2016-02-13T21:51:34Z

ljharb · 2016-02-13T21:53:07Z

@hshoff at the least, we should include all the new rules with all their options, but set to 0, so we don't miss them later.

ljharb · 2016-02-13T21:55:15Z

no-useless-constructor we should absolutely enable, we were going to make an internal plugin for that anyways. (also template-curly-spacing)

ljharb · 2016-02-14T06:52:12Z

README.md

+    // good
+    class Rey extends Jedi {
+      constructor(...args) {
+        super(...args);


this is also "bad" - a constructor that does nothing but passes the args untouched to super is also a violation of the linter rule.

- `id-blacklist` - `no-extra-label` - `no-implicit-globals` - `no-restricted-imports` - `no-unmodified-loop-condition` - `no-unused-labels` - `sort-imports` - `yield-star-spacing`

ljharb · 2016-02-14T19:52:33Z

packages/eslint-config-airbnb/rules/best-practices.js

-    'no-empty-label': 2,
+    // disallow Unnecessary Labels
+    // http://eslint.org/docs/rules/no-extra-label
+    'no-extra-label': 0,


since we already prevent labels in no-labels, i think this can be set to 2 without any additional justification in the guide (assuming it already says "no labels ever" somewhere)

hshoff · 2016-02-20T21:33:34Z

@ljharb @lencioni @kesne ready for review

@ljharb can you handle the publishing when we're ready?

ljharb · 2016-02-20T22:07:52Z

On it - I'm doing some rebasing (also making sure both devDeps and peerDeps are updated in lockstep), I'll force push it up shortly and will publish soon after.

lencioni · 2016-02-21T02:05:17Z

README.md

+      }
+
+      return false;
+    });


While I agree with this example, it doesn't seem to pertain to the text of the rule here.

Also, this example could be simplified to:

[1, 2, 3].filter((x) => { return x > 2; });

or even:

[1, 2, 3].filter(x => x > 2);

so I'm not sure it is the best to use here.

Second one is better in my opinion

…origin/harry-eslint-v2' Closes #730.

ljharb · 2016-02-21T08:52:33Z

v6.0.0 published.

mxstbr · 2016-02-21T08:54:59Z

👍 Awesome!

kesne · 2016-02-21T12:19:20Z

README.md

+    // good
+    class Rey extends Jedi {
+      constructor(...args) {
+        super(args);


Should the args object be spread into the super constructor? I.e. super(...args).

It depends on what your parent takes :)

Right, but in this case that would make this class pretty weird. I mean it's a made up example, so it doesn't really matter.

Fixed in 8a6f009

Per #730 (comment)

Per airbnb#730 (comment)

Per airbnb/javascript#730 (comment)

hshoff added 8 commits February 12, 2016 11:09

[Deps] update eslint to v2, eslint-plugin-react to v4

1bb72ab

[eslint-v2] no-empty-label => no-labels

d49a1ed

[eslint-v2] space-after/before/return/throw/case => keyword-spacing

1efb11c

[eslint-v2] fix no-labels rule

da4213c

[eslint-v2] set es6 env to true

dff5099

[eslint-v2] ecmaFeatures => parserOptions

4f32315

[eslint-v2] fix keyword-spacing style and sorting

3aa8c58

[eslint-v2] no gens, no dup props in obj literal

75807b9

This was referenced Feb 12, 2016

Migrate to eslint@2.0.0-beta #711

Closed

ESlint config errors with eslint v2 #728

Closed

ESLint Rules not compatible with ESLint 2.0.0 #731

Closed

This was referenced Feb 12, 2016

no-empty-label was renamed to no-labels in ESLint v2 #729

Closed

Update to eslint 2.0 #732

Closed

kesne mentioned this pull request Feb 13, 2016

ESLint 2.0.0 Released -- New Rules to Consider #733

Closed

lencioni mentioned this pull request Feb 13, 2016

So many errors for a single console statement #734

Closed

ljharb reviewed Feb 13, 2016
View reviewed changes

[eslint-v2] fix no-labels rule

5109c84

[eslint-v2][constructors] disallow unnecessary constructors

1cbc628

connor4312 mentioned this pull request Feb 14, 2016

Update eslint to version 2.0.0 🚀 microsoft/jojen#2

Closed

ljharb reviewed Feb 14, 2016
View reviewed changes

hshoff added 2 commits February 14, 2016 02:34

[eslint-v2][constructors] fix bad + good examples

91b8365

[eslint-v2] add new rules, disabled:

c05b2da

- `id-blacklist` - `no-extra-label` - `no-implicit-globals` - `no-restricted-imports` - `no-unmodified-loop-condition` - `no-unused-labels` - `sort-imports` - `yield-star-spacing`

hshoff mentioned this pull request Feb 14, 2016

Update to eslint to 2.x #735

Closed

larshp mentioned this pull request Feb 14, 2016

update eslint to 2.0.0 abaplint/linter-abaplint#3

Closed

ljharb mentioned this pull request Feb 14, 2016

ESLint@2.x #736

Closed

[eslint-v2][whitespace] add newline-per-chained-call rule

172dffb

ljharb reviewed Feb 14, 2016
View reviewed changes

hshoff force-pushed the harry-eslint-v2 branch from 3513243 to 80e30a1 Compare February 20, 2016 21:31

ljharb force-pushed the harry-eslint-v2 branch 2 times, most recently from ee15797 to 244bb13 Compare February 20, 2016 22:14

lencioni reviewed Feb 21, 2016
View reviewed changes

ljharb mentioned this pull request Feb 21, 2016

Unable install eslint-config-airbnb due to semver. #745

Closed

hshoff added 3 commits February 20, 2016 23:33

[eslint-v2][arrays] update array-callback-return good/bad ex

b79e951

[eslint-v2][arrays] fix example

3983d38

[changelog] update changelog for 6.0.0

0f32b96

ljharb force-pushed the harry-eslint-v2 branch 2 times, most recently from 97155ea to 0f32b96 Compare February 21, 2016 08:50

ljharb merged commit 0f32b96 into master Feb 21, 2016

ljharb added a commit that referenced this pull request Feb 21, 2016

[eslint config] Update to eslint v2: Merge remote-tracking branch '…

07e3cde

…origin/harry-eslint-v2' Closes #730.

ljharb deleted the harry-eslint-v2 branch February 21, 2016 08:51

kesne reviewed Feb 21, 2016
View reviewed changes

ljharb added a commit that referenced this pull request Feb 21, 2016

Fix no-useless-constructor example.

8a6f009

Per #730 (comment)

ljharb added enhancement semver-breaking: guide change labels Feb 21, 2016

geekjuice mentioned this pull request Feb 22, 2016

Update with airbnb/master@6.0.1 HubSpot/javascript#19

Merged

gilbox pushed a commit to gilbox/javascript that referenced this pull request Mar 21, 2016

Fix no-useless-constructor example.

29956f0

Per airbnb#730 (comment)

jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this pull request Sep 19, 2017

Fix no-useless-constructor example.

158fbad

Per airbnb#730 (comment)

sensiblegame added a commit to sensiblegame/React-BNB that referenced this pull request Oct 23, 2017

Fix no-useless-constructor example.

5034204

Per airbnb/javascript#730 (comment)

ljharb mentioned this pull request Mar 17, 2021

Is this example appropriate? (19.6) #2403

Closed

passionSeven added a commit to passionSeven/javascript that referenced this pull request Jan 27, 2023

Fix no-useless-constructor example.

b22edd7

Per airbnb/javascript#730 (comment)

Binary-Ninja-007 added a commit to Binary-Ninja-007/JavaScript_Style_Guide that referenced this pull request Aug 13, 2023

Fix no-useless-constructor example.

01e2ec9

Per airbnb/javascript#730 (comment)

harry908nilson pushed a commit to marcolane/Javascriipt that referenced this pull request Sep 1, 2023

Fix no-useless-constructor example.

80a3b6f

Per airbnb/javascript#730 (comment)

talentdev219 added a commit to talentdev219/javascript that referenced this pull request Sep 17, 2023

Fix no-useless-constructor example.

6fb32f5

Per airbnb/javascript#730 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to eslint v2 #730

Upgrade to eslint v2 #730

hshoff commented Feb 12, 2016

ljharb Feb 13, 2016

hshoff commented Feb 13, 2016

ljharb commented Feb 13, 2016

ljharb commented Feb 13, 2016

ljharb Feb 14, 2016

hshoff Feb 14, 2016

ljharb Feb 14, 2016

hshoff commented Feb 20, 2016

ljharb commented Feb 20, 2016

lencioni Feb 21, 2016

softwarespot Feb 21, 2016

ljharb commented Feb 21, 2016

mxstbr commented Feb 21, 2016

kesne Feb 21, 2016

tleunen Feb 21, 2016

kesne Feb 21, 2016

ljharb Feb 21, 2016

Upgrade to eslint v2 #730

Upgrade to eslint v2 #730

Conversation

hshoff commented Feb 12, 2016

Choose a reason for hiding this comment

hshoff commented Feb 13, 2016

Proposal:

ljharb commented Feb 13, 2016

ljharb commented Feb 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hshoff commented Feb 20, 2016

ljharb commented Feb 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ljharb commented Feb 21, 2016

mxstbr commented Feb 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment