Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in README.md #2980

Closed
wants to merge 1 commit into from
Closed

Conversation

teddy5518
Copy link

@teddy5518 teddy5518 commented May 10, 2024

Hello,

I have fixed typo in 4.2 to better doc clarity. The # in the word block does not have any meaning, and is not used throughout the document. Thus, I wanted to suggest to change Array#push to Array.push so that it increases readability and matches existing wording style such as 4.4's Array.from .

Thank you

cc. @ljharb

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array#push is a convention commonly used in documentation to mean Array.prototype.push, which is why this change would make it incorrect.

@teddy5518
Copy link
Author

Thank you for the knowledge! As a developer who is learning a lot from this style guide, I really appreciate your hard work and feedback. Thank you. :)

@ljharb ljharb marked this pull request as draft May 10, 2024 15:18
@ljharb ljharb closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants