Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully replaced the rule #2757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HemanthPaila
Copy link

@HemanthPaila HemanthPaila commented Apr 2, 2023

Fixes #2689

Duplicate of #2756.

before: 'always',
after: 'always',
}],
// Require or disallow padding lines between statements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Require or disallow padding lines between statements
// Require or disallow padding lines between statements

@@ -184,12 +184,9 @@ module.exports = {
// enforces empty lines around comments
'lines-around-comment': 'off',

// require or disallow newlines around directives
// https://eslint.org/docs/rules/lines-around-directive
'lines-around-directive': ['error', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't delete an entry, just add the new one

}],
// Require or disallow padding lines between statements
// https://eslint.org/docs/rules/padding-line-between-statements
'padding-line-between-statements': 'off',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a lot of config here that isn't specified. Please include a config that matches the lines-around-directive config we already have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lines-around-directive rule should replaced with padding-line-between-statements
6 participants