-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More comments #2630
base: master
Are you sure you want to change the base?
More comments #2630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked issue doesn't explain what it's about, and it's been closed. Can you elaborate on what you're trying to achieve?
@@ -73,6 +77,8 @@ Other Style Guides | |||
- `symbol` | |||
- `bigint` | |||
|
|||
*Goes over numbers* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems redundant
@@ -91,6 +97,8 @@ Other Style Guides | |||
- `array` | |||
- `function` | |||
|
|||
*Goes over arrays* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as does this
@@ -109,6 +117,8 @@ Other Style Guides | |||
|
|||
> Why? This ensures that you can’t reassign your references, which can lead to bugs and difficult to comprehend code. | |||
|
|||
*Vars and Consts* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
@@ -141,6 +151,8 @@ Other Style Guides | |||
<a name="references--block-scope"></a><a name="2.3"></a> | |||
- [2.3](#references--block-scope) Note that both `let` and `const` are block-scoped, whereas `var` is function-scoped. | |||
|
|||
*Goes over scopes in Javascript* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
@@ -162,6 +174,8 @@ Other Style Guides | |||
<a name="objects--no-new"></a><a name="3.1"></a> | |||
- [3.1](#objects--no-new) Use the literal syntax for object creation. eslint: [`no-new-object`](https://eslint.org/docs/rules/no-new-object) | |||
|
|||
*Goes over objects* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
<Foo style={{ left: "20px" }} /> | ||
<Foo className='bad example' /> | ||
|
||
// good | ||
<Foo style={{ left: '20px' }} /> | ||
<Foo className="good example" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these MUST remain as "style" with an object literal; there's nothing wrong with the current examples.
#2626