Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines-around-directive rule should replaced with padding-line-between-statements #2689

Open
mvorisek opened this issue Dec 7, 2022 · 9 comments · May be fixed by #2757
Open

lines-around-directive rule should replaced with padding-line-between-statements #2689

mvorisek opened this issue Dec 7, 2022 · 9 comments · May be fixed by #2757

Comments

@mvorisek
Copy link

mvorisek commented Dec 7, 2022

see eslint/eslint#16629 (comment) from the eslint maintainer

@HemanthPaila
Copy link

Hi there,

I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress.

Thanks!

@ljharb
Copy link
Collaborator

ljharb commented Mar 31, 2023

@HemanthPaila theres no need to request assignment; most open source projects don’t operate that way. Just make a PR and link it to the issue.

@HemanthPaila
Copy link

Thanks @ljharb . I am on it.

@HemanthPaila
Copy link

I made a PR on this issue. could you please review and merge it?

@HemanthPaila HemanthPaila linked a pull request Apr 2, 2023 that will close this issue
@HemanthPaila
Copy link

Hello sir i made another PR could you please review it once?

@ljharb
Copy link
Collaborator

ljharb commented Apr 2, 2023

@HemanthPaila please don't make duplicate PRs - now both #2756 and #2757 must remain open and be kept in sync. I've reviewed it, and in the future you don't need to ask for review, you can just wait more than a few minutes :-)

@HemanthPaila
Copy link

Sir could you please clarify my doubt:
- What I want to add to the issue for a successful merge.
- I regret removing the entry, but I will correct the issue by returning it to the appropriate place.

@speedywarp
Copy link

is the issue resolved?

@ljharb
Copy link
Collaborator

ljharb commented Aug 6, 2024

No, the linked PR, #2757, has unresolved comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants