Replace "incorrect" types to make project generation work with xcodeproj

[fdiaz]

Buck currently outputs an XML for project.pbxproj where runOnlyForDeploymentPostprocessing and dstSubfolderSpec are treated as integer.

			<key>runOnlyForDeploymentPostprocessing</key>
			<integer>1</integer>
			<key>dstSubfolderSpec</key>
			<integer>16</integer>

When trying to open the .xcodeproj file with xcodeproj we're getting:

[Xcodeproj] Type checking error: got Fixnum for attribute: Attribute dstSubfolderSpec (type: simple, classes: [String], owner class: PBXCopyFilesBuildPhase)

This seems to be a bug in xcodeproj itself.

To work around this, I'm forcing these 2 keys to have Strings as values instead of Int. After doing this, xcodeproj can succesfully open our project.

cc @dfed @bachand @shepting

[dfed]

@fdiaz any reason not to contribute this back to facebook/buck?

[donholly]

@fdiaz did you end up submitting this to facebook/buck? Running into this issue myself now and I think it'd be a pain to move over to airbnb/buck for us as all of our scripts expect to install buck from Homebrew :(

[fdiaz]

I've been just lazy but I need to do this! I'll do this tomorrow. Thanks for the reminder @donholly !

[donholly]

@fdiaz 🙏 awesome news - thank you!

We ended up having to fork Buck as well and pulled this change into ours. We also came across a similar issue for ProxyType - have you run into this one?

Clubroom@8fa5ae5

[fdiaz]

@donholly we started moving away from xcodeproj so we haven't run into this anymore. It's highly likely this happens in different places though since Buck and xcodeproj seem to be working under different assumptions for the XML output.

[fdiaz]

Upstream PR facebook#2257