Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unfactored ma-pddl generation #494

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Conversation

Alee08
Copy link
Member

@Alee08 Alee08 commented Sep 29, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (862c4b2) 85.03% compared to head (71a63ce) 84.88%.
Report is 80 commits behind head on master.

Files Patch % Lines
unified_planning/io/ma_pddl_writer.py 0.00% 130 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   85.03%   84.88%   -0.16%     
==========================================
  Files         198      198              
  Lines       26064    26111      +47     
==========================================
  Hits        22164    22164              
- Misses       3900     3947      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alvalentini alvalentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alee08 Can you extend the notebook MA-PDDL I/O showing this new features?

unified_planning/io/ma_pddl_writer.py Show resolved Hide resolved
@alvalentini alvalentini merged commit a6dacbd into master Nov 15, 2023
8 checks passed
@alvalentini alvalentini deleted the MAPDDLWriter-unfactored branch November 15, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants