Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Replanner error disabling #485

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fix Replanner error disabling #485

merged 3 commits into from
Sep 5, 2023

Conversation

Framba-Luca
Copy link
Contributor

This PR:

  • Adds the possibility of disabling the checks in the replanner constructor
  • cleans the SequentialSimulator structure
  • fixes small error report when the name in a problem is duplicated

…sabling the checks in the replanner constructor -cleaned SequentialSimulator structure -fixed small error report when the name in a problem is duplicated
@Framba-Luca Framba-Luca self-assigned this Sep 4, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.02% 🎉

Comparison is base (d5e5dcd) 84.98% compared to head (382f0a7) 85.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   84.98%   85.01%   +0.02%     
==========================================
  Files         198      198              
  Lines       26006    26019      +13     
==========================================
+ Hits        22102    22120      +18     
+ Misses       3904     3899       -5     
Files Changed Coverage Δ
unified_planning/model/htn/hierarchical_problem.py 89.65% <0.00%> (ø)
unified_planning/model/mixins/actions_set.py 90.47% <0.00%> (ø)
unified_planning/model/mixins/agents_set.py 79.41% <0.00%> (ø)
unified_planning/model/mixins/fluents_set.py 86.74% <0.00%> (ø)
unified_planning/model/mixins/objects_set.py 87.71% <0.00%> (ø)
unified_planning/model/mixins/user_types_set.py 91.07% <0.00%> (ø)
unified_planning/engines/factory.py 74.50% <100.00%> (+0.05%) ⬆️
unified_planning/engines/mixins/replanner.py 84.90% <100.00%> (+6.05%) ⬆️
...ed_planning/engines/mixins/sequential_simulator.py 92.75% <100.00%> (+0.10%) ⬆️
unified_planning/engines/replanner.py 94.91% <100.00%> (+1.69%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alvalentini alvalentini merged commit 13c2ab0 into master Sep 5, 2023
8 checks passed
@alvalentini alvalentini deleted the meta-engine branch September 5, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants