Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static method to Engine class to define its configuration space #470

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

alvalentini
Copy link
Member

No description provided.

@alvalentini
Copy link
Member Author

@DimitriWeiss I added the ConfigurationSpace to tamer and pyperplan in this and this commits.

If for you are ok, I will proceed with the merge of this PR.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01% ⚠️

Comparison is base (d4d3b41) 84.98% compared to head (c522272) 84.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   84.98%   84.98%   -0.01%     
==========================================
  Files         198      198              
  Lines       26002    26006       +4     
==========================================
+ Hits        22099    22102       +3     
- Misses       3903     3904       +1     
Files Changed Coverage Δ
unified_planning/engines/engine.py 94.02% <75.00%> (-1.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alvalentini alvalentini merged commit 6b51ec1 into master Aug 10, 2023
8 checks passed
@alvalentini alvalentini deleted the add-engines-configuration-space branch August 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants