Configurable max packet size #400
Conversation
jlaine
force-pushed
the
max-packet-size
branch
2 times, most recently
from
8361d46 to
7da12be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 4542 4552 +10
=========================================
+ Hits 4542 4552 +10
☔ View full report in Codecov by Sentry. |
jlaine
force-pushed
the
max-packet-size
branch
from
7da12be to
3ea2ad6
Compare
jlaine
force-pushed
the
max-packet-size
branch
from
3ea2ad6 to
724ddd5
Compare
|
From reading the RFCs it looks as though we should be using We should also lower the default value to 1200 in line with RFC 9000, as pointed out by @Arvind2222 |
jlaine
force-pushed
the
max-packet-size
branch
3 times, most recently
from
beaff3e to
c926bcb
Compare
| @@ -539,8 +545,11 @@ def datagrams_to_send(self, now: float) -> List[Tuple[bytes, NetworkAddress]]: | |||
| builder.max_flight_bytes = ( | |||
| self._loss.congestion_window - self._loss.bytes_in_flight | |||
| ) | |||
| if self._probe_pending and builder.max_flight_bytes < PACKET_MAX_SIZE: | |||
| builder.max_flight_bytes = PACKET_MAX_SIZE | |||
| if ( | |||
There was a problem hiding this comment.
I am not sure this is correct. I think this should be exactly 1200 bytes.
|
On the whole this PR is now in a good place. I'm still wondering about naming though, as the
=> Should our new setting reflect the fact it applies to egress? Like |
jlaine
force-pushed
the
max-packet-size
branch
3 times, most recently
from
b985ed0 to
cc41779
Compare
Also set the default maximum datagram size to 1200 bytes, in line with RFC 9000. Co-authored-by: Jeremy Lainé <jeremy.laine@m4x.org>
jlaine
force-pushed
the
max-packet-size
branch
from
cc41779 to
bacc1e8
Compare
|
@jlaine Was doing a retro, I think if we can keep these Configs in good place since the RFC is still new and might change in future. Your call ! |
This PR adds the possibility of configuring the maximum QUIC packet size. Increasing the packet size to make full use of MTU has beneficial performance improvements. It also simplifies future potential implementation of Path MTU Discovery.